Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag --digest-changes-only to filter commits for modules and plugins #3560

Merged
merged 3 commits into from
Jan 2, 2025

Conversation

emcfarlane
Copy link
Contributor

@emcfarlane emcfarlane commented Dec 20, 2024

This adds a flag --digest-changes-only to the commands buf registry {module,plugin} commit list to filter out any commits without a changed digest. By default all commits are listed. This is similar to the UI view "Hide commits with no changes" in the BSR.

This adds a flag `--only-changes` to the commands `buf registry {module,plugin}
commit list` to filter out any commits without a changed digest. By
default all commits are listed. This is similar to the UI view "Hide
commits with no changes" in the BSR.
@emcfarlane emcfarlane requested a review from doriable December 20, 2024 14:42
Copy link
Contributor

github-actions bot commented Dec 20, 2024

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedDec 31, 2024, 2:54 PM

@bufdev
Copy link
Member

bufdev commented Dec 20, 2024

Need to workshop naming here live. The "no changes" labeling always bothered me a tad, so we can hammer out both at once on Tuesday! Prob will be a 5-10 minute call.

@mfridman
Copy link
Member

More of a driveby to suggest some names: --content-only, --filter-content-only or --source-only.

Maybe just me, but I've always thought about this behavior as "metadata" (vcs url, deps) vs "content" (proto, license, etc.) changes.

@doriable
Copy link
Member

I think that maybe incorporating the term digest, e.g. --digest-changes-only, might be more clear, since new commits are created for changes in source control URL and we otherwise have commit squashing on the BSR. Otherwise, this all looks reasonable to me!

@bufdev
Copy link
Member

bufdev commented Dec 31, 2024

--digest-changes-only sounds good to me!

@emcfarlane emcfarlane changed the title Add flag --only-changes to filter commits for modules and plugins Add flag --digest-changes-only to filter commits for modules and plugins Dec 31, 2024
@emcfarlane emcfarlane merged commit e03f5be into main Jan 2, 2025
12 checks passed
@emcfarlane emcfarlane deleted the ed/listCommitsOnlyChanges branch January 2, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants