docs: update sdk section #49
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add timeout and pooling information
add timeout and pooling information
add timeout and pooling information
add timeout and pooling information
✅ Deploy Preview for bucketeer-docs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
htessaro
commented
Jan 31, 2024
Comment on lines
139
to
153
| ```dart showLineNumbers | ||
| /// It will unlock without waiting until the fetching variation process finishes | ||
| int timeout = 1000; | ||
| int timeout = 5000; | ||
|
|
||
| await BKTClient.initialize(config: config, user: user, timeoutMillis: timeout); | ||
| final client = BKTClient.instance; | ||
| if (result.isSuccess) { | ||
| final client = BKTClient.instance; | ||
| if (showNewFeature) { | ||
| /// The Application code to show the new feature | ||
| } else { | ||
| /// The code to run if the feature is off | ||
| } | ||
| } else { | ||
| /// Handle the error when there is no cache or the cache is not updated | ||
| } |
There was a problem hiding this comment.
@cre8ivejp, the original code didn't use a conditional to treat timeout errors. I tried to adapt the code from the update section. However, I don't know if it's correct.
cre8ivejp
reviewed
Feb 1, 2024
cre8ivejp
reviewed
Feb 1, 2024
change tables and remove links to nodejs and go pages.
cre8ivejp
reviewed
Feb 1, 2024
cre8ivejp
reviewed
Feb 1, 2024
docs/sdk/index.mdx
Outdated
| <td><CheckSVG/></td> | ||
| </tr> | ||
| <tr> | ||
| <td>Clone</td> |
There was a problem hiding this comment.
There is no Clone feature.
Please remove this.
There was a problem hiding this comment.
Removed. However, in previous comments, you mentioned a Clone feature that Go SDK has. I probably misunderstand. But what was that about?
There was a problem hiding this comment.
In this comment, I mentioned Close.
#49 (comment)
cre8ivejp
reviewed
Feb 1, 2024
cre8ivejp
reviewed
Feb 1, 2024
cre8ivejp
reviewed
Feb 2, 2024
| --- | ||
|
|
||
| import Tabs from '@theme/Tabs'; | ||
| import TabItem from '@theme/TabItem'; | ||
|
|
||
| This category contains topics explaining how to configure Bucketeer's Flutter SDK. | ||
|
|
||
| :::caution Flutter SDK Version (Beta) | ||
|
|
||
| The Flutter JS SDK is currently in its Beta stage. |
There was a problem hiding this comment.
Suggested change
| The Flutter JS SDK is currently in its Beta stage. | |
| The Flutter SDK is currently in its Beta stage. |
|
|
||
| The Flutter JS SDK is currently in its Beta stage. | ||
|
|
||
| If you find any issues or have suggestions for improvement, feel free to open an [issue](https://github.com/bucketeer-io/flutter-client-sdk/issues). |
There was a problem hiding this comment.
Suggested change
| If you find any issues or have suggestions for improvement, feel free to open an [issue](https://github.com/bucketeer-io/flutter-client-sdk/issues). | |
| If you find any issues or have suggestions for improvement, feel free to open an [issue](https://github.com/bucketeer-io/flutter-client-sdk/issues). | |
| The SDK doesn't support Flutter Web yet. All contributions are welcome! |
|
|
||
| await BKTClient.initialize(config: config, user: user, timeoutMillis: timeout); | ||
| final client = BKTClient.instance; | ||
| final result = await BKTClient.initialize(config: config, user: user, timeoutMillis: timeout); |
There was a problem hiding this comment.
Please replace the whole code block with the following.
Suggested change
| final result = await BKTClient.initialize(config: config, user: user, timeoutMillis: timeout); | |
| /// It will unlock without waiting until the fetching variation process finishes | |
| const int timeout = 5000; | |
| final result = await BKTClient.initialize(config: config, user: user, timeoutMillis: timeout); | |
| if (result.isSuccess) { | |
| const client = BKTClient.instance; | |
| if (showNewFeature) { | |
| /// The Application code to show the new feature | |
| } else { | |
| /// The code to run if the feature is off | |
| } | |
| } else { | |
| /// Handle the error when there is no cache or the cache is not updated | |
| } |
|
@heitortessaro, I left a few comments. Please take a look when you have time. |
|
Closing this in favor of #50 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.