Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 preparation #80

Merged
merged 2 commits into from
Oct 27, 2022
Merged

V2 preparation #80

merged 2 commits into from
Oct 27, 2022

Conversation

ndeet
Copy link
Collaborator

@ndeet ndeet commented Oct 27, 2022

Fixes #57 deprecation warnings in PHP 8.1
Fixes #35 function name but not the second part of the paid invoice amount (added followup #79)

@@ -83,7 +83,7 @@ public function isNew(): bool
return $data['status'] === self::STATUS_NEW;
}

public function isFullyPaid(): bool
public function isSettled(): bool
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@ndeet ndeet merged commit f474251 into btcpayserver:master Oct 27, 2022
@ndeet ndeet deleted the v2-preparation branch October 27, 2022 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants