Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create get_orderID.php #121

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

julienheinen
Copy link

this php file can be used to search for an orderID, to check a payment for example. The user can do this manually, in a form for example. This is because he or she has the orderID, and can therefore verify his or her purchase on a website.

this php file can be used to search for an orderID, to check a payment for example. The user can do this manually, in a form for example. This is because he or she has the orderID, and can therefore verify his or her purchase on a website.
@ndeet
Copy link
Collaborator

ndeet commented Nov 22, 2024

Hey, sorry for the late review and thanks for your contribution.

This example is better to be fit into the existing examples/get_invoice.php file, see the other examples. All it does is to get invoices filtered by order IDs

no need to get apik key from .env file etc. also please remove commented code that has no usage

thank you

I remove the apik key from .env file and the commented code that has no usage
@julienheinen
Copy link
Author

Hello, I deleted the apik key from .env file and the commented lines that had no use.

@ndeet
Copy link
Collaborator

ndeet commented Dec 18, 2024

Thank you very much, one last thing would be to move it into the existing examples/get_invoice.php file and refactor the code to match the other examples there.

@julienheinen
Copy link
Author

Hello,

Thank you for your reply.

I'm wondering if it wouldn't be better to create a separate file for orderID retrieval, as the purpose of this file is different from that of get_invoice.php. Indeed, get_invoice.php contains no functions and concentrates on retrieving invoice information, whereas the new file would concentrate on checking orderIDs.

What do you think? Should I still add this code to get_invoice.php or create a new get_orderID.php file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants