Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend Shape::faces_along_ray to return a LineFaceHitPoint with more info #147

Merged
merged 3 commits into from
Nov 12, 2023
Merged

Extend Shape::faces_along_ray to return a LineFaceHitPoint with more info #147

merged 3 commits into from
Nov 12, 2023

Conversation

mkovaxx
Copy link
Collaborator

@mkovaxx mkovaxx commented Nov 8, 2023

Closes #146

As Mike Tyson said (paraphrasing):

Everybody has a plan until they get hit in the face.

By a line. With parameters, and stuff.

@mkovaxx mkovaxx self-assigned this Nov 8, 2023
@mkovaxx mkovaxx requested a review from bschwind November 8, 2023 15:23
@mkovaxx mkovaxx marked this pull request as ready for review November 8, 2023 15:36
bschwind
bschwind approved these changes Nov 12, 2023
View reviewed changes
Copy link
Owner

@bschwind bschwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just needs a rename!

crates/opencascade/src/primitives/shape.rs Outdated Show resolved Hide resolved
examples/src/keycap.rs Show resolved Hide resolved
@mkovaxx mkovaxx requested a review from bschwind November 12, 2023 05:10
@mkovaxx mkovaxx mentioned this pull request Nov 12, 2023
Open
bschwind
bschwind approved these changes Nov 12, 2023
View reviewed changes
Copy link
Owner

@bschwind bschwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bschwind bschwind merged commit 0adabcb into bschwind:main Nov 12, 2023
4 checks passed
@mkovaxx mkovaxx deleted the mate_face_line_intersection branch June 9, 2024 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bschwind bschwind bschwind approved these changes

Assignees

@mkovaxx mkovaxx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance faces_along_ray() function
2 participants
@mkovaxx @bschwind