-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add button to clear history for one item #260
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice idea to place the "clear" button directly in the popup!
// a new entry was added to the popup matching list, need to refresh the count | ||
if (!login.inCurrentHost && login.recent.count === 1) { | ||
// an entry was added / removed to the popup matching list, need to refresh the count | ||
if (!login.inCurrentHost) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we maybe use && login.recent.count < 2
? in end end badge count changes only when you have just used a new entry, or when you removed it...
".part.search input[type='text']" | ||
) | ||
.dispatchEvent(new Event("input")); | ||
result.doAction("clearRecent"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pressing on the "Clear usage" button for some reason requires me to touch Yubikey, not sure why, but it definitely shouldn't, as I am not intending to decrypt the password entry... And if I don't touch Yubikey, then the recent will not be cleared 🤔
@@ -0,0 +1,10 @@ | |||
<svg id="outline" height="512" viewBox="0 0 512 512" width="512" xmlns="http://www.w3.org/2000/svg"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return !this.currentDomainOnly || result.inCurrentHost || result.recent.when; | ||
}) | ||
.map(function (result) { | ||
console.log(result); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably no need for keeping console.log
🙂
HI guys, |
@ieggel It probably won't be, as there's another PR currently under review that's making significant changes to the UI rendering. The feature will need to be re-implemented on top of that. |
What
Why