global update

[fanatid]

Didn't see this code before, mostly this PR apply standard

[calvinmetcalf]

why are we renaming the readme ? it was lowercase to make completion from the comand line easier

[fanatid]

I never thought about it, but for node packages usually README.md uses, right?

[calvinmetcalf]

the tendency is to make the special files allcaps, but they are technically case insensitive due to windows file system being case insensitive and most mac file systems being mostly case insensitive.

[fanatid]

it's bad that file systems are insensitive, do you really want to keep lowercase?

[calvinmetcalf]

eh since license is all caps as well, we should probably make this one all caps as well

[calvinmetcalf]

why change this to a for loop, if we are using like a while loop?

[fanatid]

do you think while will be more readable?

[calvinmetcalf]

in this context yes I believe a while loop is much more readable then the equivalent for loop considering the for loop is acting like the while loop by having an empty 3 argument

[fanatid]

what's about do-while?

[calvinmetcalf]

that would work

[fanatid]

updated

[calvinmetcalf]

thanks for cleaning this up, I have a few nits and questions but it looks overall helpful

[calvinmetcalf]

I thought we were going to do a

do {} while() loop ?

[fanatid]

Yes, I wanted use do-while here, but current looks better than:

  var len = priv.modulus.byteLength()
  var r
  do {
    r = new BN(randomBytes(len))
  } while (r.cmp(priv.modulus) >= 0 || !r.umod(priv.prime1) || !r.umod(priv.prime2))
  return r

agree?

[calvinmetcalf]

wouldn't the equivalent be

  var len = priv.modulus.byteLength()
  do {
    var r = new BN(randomBytes(len))
  } while (r.cmp(priv.modulus) >= 0 || !r.umod(priv.prime1) || !r.umod(priv.prime2))
  return r

[fanatid]

you're right, it will work, but I don't like idea return variable that was defined in nested block scope

[calvinmetcalf]

but that's what your code does currently

[fanatid]

sorry, I mean return variable from current scope that was defined in nested scope
right now variable defined and returned from one scope

[fanatid]

for me (personal preference):

not ok:

function f () {
 if (1) { var x = 2 }
 return x
}

ok:

function f () {
 if (1) { var x = 1; return x }
}

[calvinmetcalf]

yeah I was mis reading the change, I thought you were still returning r, anywho I don't think the while true is much of an improvement, we should probably either ditch this change for now and not include it in this particular pull.

[fanatid]

okay, updated to old code
can you make change without pull after merge?

[fanatid]

@calvinmetcalf Thank you!
Any plans about publishing changes? At least new code uses toArrayLike from bn.js.

[dcousens]

@calvinmetcalf in a .inputrc:

# tab complete should ignore case
set completion-ignore-case on
set completion-map-case on