Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update variant page grp frequency table styling #1653

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

rileyhgrant
Copy link
Contributor

@rileyhgrant rileyhgrant commented Nov 5, 2024

The Variant page's genetic ancestry group frequency table recently had its styling updated to make the division between genetic ancestry groups more clear, as the subtler grey dividing line between the total freq information and the sex specific freq information in a given ancestry group was thicker than the lines between the groups.

This change unintentionally made the total sex specific (XX/XY) frequencies dividers become less clear. This PR slightly modifies the styling to make the header and footer more distinct than individual rows, and make clear the XX/XY section of the table.

It keeps the changes to thicknesses of lines that were requested and modified in a previous PR.

  • Production (current) stylings on left, PR stylings on right
    Screenshot 2024-11-05 at 16 13 10

The main change is to make the line dividing XX/XY less distinct than the lines above and below it

i.e. modify stylings here

Production:
Screenshot 2024-11-05 at 16 16 23

PR:
Screenshot 2024-11-05 at 16 15 55

Copy link
Contributor

@phildarnowsky-broad phildarnowsky-broad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good just one very small touchup noted, good to merge once you've done that

}[]
}

type OwnPopulationsTableProps = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while we're in here let's get rid of the Own here and call this PopulationTableProps or even just Props if it's not ambiguous. IIRC the Own that crops up in lots of names of types of component properties is an artifact of how the automatic ts-migrate script converted Proptypes, neither of which is relevant anymore.

@rileyhgrant rileyhgrant merged commit b2501e6 into main Nov 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants