Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUS-2552: Fix Illogical OVERLAP #242

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

justinchang91
Copy link
Contributor

Description

Make it so that OVERLAP returns true if you are evaluating 2 empty arrays

Test Coverage

  • unit

References

GUS-2552

@countcain
Copy link
Member

let's also bump the version as in this PR https://github.com/briza-insurance/illogical/pull/241/files

I will help out make a release to npm.

Copy link
Contributor

@atoledo atoledo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justinchang91 justinchang91 merged commit c192fad into master Mar 21, 2024
1 check passed
@rthreei rthreei deleted the feature/gus-2552-fix-illogical-overlap branch March 22, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants