Make it so OVERLAP, [], [] results in True

briza-insurance · Mar 21, 2024 · ebfad9d · ebfad9d
1 parent a7c408e
commit ebfad9d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/src/expression/comparison/__test__/unit/overlap.test.ts b/src/expression/comparison/__test__/unit/overlap.test.ts
@@ -34,6 +34,7 @@ describe('Expression - Comparison - Overlap', () => {
       new Collection([new Value('1'), new Value('2')]),
       true,
     ],
+    [new Collection([]), new Collection([]), true],
     // Truthy - Bi-directional
     [
       new Collection([new Value(1), new Value(2), new Value(5)]),

diff --git a/src/expression/comparison/overlap.ts b/src/expression/comparison/overlap.ts
@@ -40,6 +40,10 @@ export class Overlap extends Comparison {
 
     const leftArray = left as (string | number)[]
     const rightArray = right as (string | number)[]
+
+    if (leftArray.length === 0 && rightArray.length === 0) {
+      return true
+    }
     return leftArray.some((element) => rightArray.includes(element))
   }