Include ClickHouse beta JSON type results in super command doc #5513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philrz
commented
Dec 3, 2024
| /etc/apt/sources.list.d/clickhouse.list | ||
| sudo apt-get update | ||
| sudo DEBIAN_FRONTEND=noninteractive apt-get install -y clickhouse-server clickhouse-client | ||
| sudo cp clickhouse-storage.xml /etc/clickhouse-server/config.d |
There was a problem hiding this comment.
I moved the ClickHouse installation after the cloning of the super repo so I could grab this XML config file to make sure the instance SSD was used for DB storage.
philrz
commented
Dec 3, 2024
| @@ -759,7 +766,7 @@ For the _search_ test, we'll search for the string pattern | |||
| ``` | |||
| in the field `payload.pull_request.body` | |||
| and we'll just count the number of matches found. | |||
| The number of matches is small (3) so the query performance is dominated | |||
| The number of matches is small (2) so the query performance is dominated | |||
There was a problem hiding this comment.
I happened to notice and fix this small error that had been there previously. It's actually the "Search+" test that returns 3 matches.
mccanne
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changing
Query performance results are added to the
supercommand doc for the ClickHouse beta JSON type.Why
In initial attempts on our Macbooks to load the test data into a table column of this type, we consistently experienced an "too many open files" error. However, when I got the automated scripts running on a larger AWS instance in #5506, I found the data would load successfully into ClickHouse, hence the motivation to circle back and support running this permutation in the scripts and including the results in the doc,