simplify file not found messages - less is more #5414
Merged
+31
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit simplifies file-not-found message by dropping the extra output of the file:/// absolute paths. We also noticed that "super:" was prefixed some of the times to errors and not others, so we took the "super:" prefix out in the one place it was used. When a data lake object is not found, the full path is printed. This happens on the vaccum test. This is not the right UX when trying to scanned vaccumed parts of the lake, but it's how it works for now.
nwt
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit simplifies file-not-found message by dropping the extra output of the file:/// absolute paths. We also noticed that "super:" was prefixed some of the times to errors and not others, so we took the "super:" prefix out in the one place it was used.
When a data lake object is not found, the full path is printed. This happens on the vaccum test. This is not the right UX when trying to scanned vaccumed parts of the lake, but it's how it works for now.
Closes #1137