ast.Errors #5122
ast.Errors #5122
Conversation
mattnibs
force-pushed
the
ast-error
branch
3 times, most recently
from
261d933 to
55d357c
Compare
This commit introduces ast.Errors- an error type that should be used whenever a generated error refers to a place in the query source. This commit switches the parser package to use ast.Error but a follow up commit will use ast.Errors for the semantic package as well.
| @@ -34,34 +34,34 @@ outputs: | |||
| - name: stderr | |||
| data: | | |||
| =1= | |||
| error parsing Zed at column 11: | |||
| error parsing Zed (line 1, column 11): | |||
There was a problem hiding this comment.
This looks like a purely cosmetic change. Can we save it for a separate PR?
There was a problem hiding this comment.
Not really since with semantic errors you have different error messages that may not syntactically work in the "append this to a sentence" way that errors are currently formatted.
| Query(ctx context.Context, head *lakeparse.Commitish, src string) (zio.ReadCloser, error) | ||
| QueryWithControl(ctx context.Context, head *lakeparse.Commitish, src string) (zbuf.ProgressReadCloser, error) |
There was a problem hiding this comment.
I think it should be this way since if you let lake/api/api do the ConcatSources for you won't be able to map error locations to your source set.
There was a problem hiding this comment.
I was thinking that the mapping would continue to happen inside these methods in the same way it effectively does now. Shifting that burden to the caller seems like it makes for a more complicated interface since the caller now has to deal with parser.ConcatSource and clierrors.Format.
Does shifting that burden have some benefit I'm not seeing?
There was a problem hiding this comment.
I eventually want to rewrite the error text to use asni escape sequences for pretty console output- where should the package that formats the error messages go?
|
Closing in favor of #5128 |
This commit introduces ast.Errors- an error type that should be used whenever a generated error refers to a place in the query source. This commit switches the parser package to use ast.Error but a follow up commit will use ast.Errors for the semantic package as well.