Enabled JSON and ZSON color by default #5114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the behavior of the ZSON and JSON outputs where if the writer is writing to a terminal the output will be colorized- independent of whether the output is indented or not.
nwt
reviewed
Apr 24, 2024
Comment on lines
+26
to
+29
| colorDisabled bool | ||
| } | ||
|
|
||
| func NewFormatter(pretty int, colorDisabled bool, persist *regexp.Regexp) *Formatter { |
There was a problem hiding this comment.
I think this would be clearer with color bool instead.
There was a problem hiding this comment.
The problem with this is that color = true wouldn't necessarily mean color is enabled since it depends when the writer is outputting to a terminal.
There was a problem hiding this comment.
Ah, right. To make that work we'd need to get rid of pkg/terminal/color.Enabled. Let's do that later.
There was a problem hiding this comment.
Agreed I think we should get rid of that but yeah, later.
nwt
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the behavior of the ZSON and JSON outputs where if the writer is writing to a terminal the output will be colorized- independent of whether the output is indented or not.