Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamic cut: fix bug in keys #4832

Merged
merged 2 commits into from
Nov 5, 2023
Merged

dynamic cut: fix bug in keys #4832

merged 2 commits into from
Nov 5, 2023

Conversation

mattnibs
Copy link
Collaborator

@mattnibs mattnibs commented Oct 27, 2023

Fix bug in dynamic cut where two output records with different keys but equal value types would overwrite each other.

Closes #4830

@mattnibs mattnibs requested a review from a team October 27, 2023 18:09
Fix bug in dynamic cut where two output records with different keys
but equal value types would overwrite each other.

Closes 4830
@mattnibs mattnibs requested a review from nwt November 4, 2023 14:36
Copy link
Member

@nwt nwt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:!

Copy link
Contributor

@philrz philrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Branch tests out well for me too! 👍

@mattnibs mattnibs merged commit 5ef508c into main Nov 5, 2023
3 checks passed
@mattnibs mattnibs deleted the fix-dynamic-cut branch November 5, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cut not producing output equivalent to put+drop
3 participants