Add map function #4806

mattnibs · 2023-10-12T22:35:55Z

The map function that applies a function to every element in an array or set value.

Also: rename the map aggregator to collect_map to avoid collision with this new function.

nwt · 2023-10-23T17:36:56Z

compiler/ast/dag/expr.go

+	MapCall struct {
+		Kind  string `json:"kind" unpack:""`
+		Expr  Expr   `json:"expr"`
+		Inner Expr   `json:"inner"`
+	}


Is there a downside to using Call rather than adding MapCall?

Its kind of a different thing than a call. A call is made of args that you get the value of all by passing this into it, a map call you evaluate this, then iterate over each value an call the inner eval on each value. So I kind of think this should remain MapCall

runtime/expr/agg/map.go

The map function that applies a function to every element in an array or set value. Also: rename the map aggregator to collect_map to avoid collision with this new function. Closes #4610

docs/language/functions/README.md

Co-authored-by: Noah Treuhaft <[email protected]>

docs/language/functions/map.md

runtime/expr/map.go

Co-authored-by: Noah Treuhaft <[email protected]>

docs/language/functions/map.md

Co-authored-by: Noah Treuhaft <[email protected]>

mattnibs force-pushed the map-fn branch 3 times, most recently from 9977402 to 7e6986d Compare October 12, 2023 22:40

mattnibs requested a review from a team October 12, 2023 22:41

mattnibs force-pushed the map-fn branch 3 times, most recently from c3cfdca to eadfee5 Compare October 12, 2023 23:33

philrz linked an issue Oct 17, 2023 that may be closed by this pull request

Call a function on every element of a complex value #4610

Open

mattnibs force-pushed the semantic-func-check branch 3 times, most recently from 94924cf to f9343e4 Compare October 18, 2023 19:20

Base automatically changed from semantic-func-check to main October 19, 2023 17:37

mattnibs force-pushed the map-fn branch from eadfee5 to 541610c Compare October 19, 2023 17:38

nwt reviewed Oct 23, 2023

View reviewed changes