Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix panic compiling record expression with duplicate field #4789

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Fix panic compiling record expression with duplicate field #4789

merged 2 commits into from
Oct 2, 2023

Conversation

nwt
Copy link
Member

@nwt nwt commented Sep 29, 2023

Closes #3365.

@nwt nwt requested a review from a team September 29, 2023 18:37
mattnibs
mattnibs reviewed Sep 29, 2023
View reviewed changes
compiler/kernel/expr.go Outdated Show resolved Hide resolved
@nwt nwt merged commit fb9a8b3 into main Oct 2, 2023
3 checks passed
@nwt nwt deleted the compileRecordExpr-duplicate-field branch October 2, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattnibs mattnibs mattnibs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

compileRecordExpr should check for dup columns
2 participants
@nwt @mattnibs