Remove runtime/sam/expr.SortStable (#5137)

slices.SortStableFunc does the same thing and should be faster since it doesn't rely on sort.Interface.
brimdata · Jun 7, 2024 · 711bf9f · 711bf9f
1 parent 2037e11
commit 711bf9f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 7 deletions.
diff --git a/runtime/sam/expr/sort.go b/runtime/sam/expr/sort.go
@@ -266,12 +266,6 @@ func (s *sortStableReader) Read() (*zed.Value, error) {
 	return val, nil
 }
 
-// SortStable performs a stable sort on the provided records.
-func SortStable(records []zed.Value, compare CompareFn) {
-	slice := &RecordSlice{records, compare}
-	sort.Stable(slice)
-}
-
 type RecordSlice struct {
 	vals    []zed.Value
 	compare CompareFn

diff --git a/runtime/sam/op/groupby/groupby.go b/runtime/sam/op/groupby/groupby.go
@@ -4,6 +4,7 @@ import (
 	"context"
 	"encoding/binary"
 	"errors"
+	"slices"
 	"sync"
 
 	"github.com/brimdata/zed"
@@ -246,7 +247,7 @@ func (o *Op) run() {
 			if res == nil {
 				break
 			}
-			expr.SortStable(res.Values(), o.agg.keyCompare)
+			slices.SortStableFunc(res.Values(), o.agg.keyCompare)
 			done, ok := o.sendResult(res, nil)
 			if !ok {
 				return