Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch license errors and provide meaningful feedback #41

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

cmutel
Copy link
Member

@cmutel cmutel commented Dec 24, 2024

No description provided.

@cmutel cmutel requested a review from jsvgoncalves December 24, 2024 11:58
@cmutel
Copy link
Member Author

cmutel commented Dec 24, 2024

@tngTUDOR The failing tests are syntax errors for Python 3.8 - do you think we can drop support for 3.8?

ecoinvent_interface/core.py Outdated Show resolved Hide resolved
with (
open(out_filepath, "rb") as source,
open(directory / filename, "w", encoding="utf-8") as target,
):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$ git add -p is your friend to avoid committing unrelated changes.

tests/test_process_interface.py Show resolved Hide resolved
@cmutel cmutel requested a review from jsvgoncalves January 6, 2025 12:40
@@ -179,7 +179,10 @@ def _get_all_reports(self) -> dict:
Client ID: {self.client_id}
"""
logger.debug(message)
return requests.get(reports_url, headers=headers, timeout=20).json()
response = requests.get(reports_url, headers=headers, timeout=20).json()
if response == {"detail": "Forbidden"}:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if response == {"detail": "Forbidden"}:
if response.status_code == 401:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants