-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catch license errors and provide meaningful feedback #41
base: main
Are you sure you want to change the base?
Conversation
@tngTUDOR The failing tests are syntax errors for Python 3.8 - do you think we can drop support for 3.8? |
with ( | ||
open(out_filepath, "rb") as source, | ||
open(directory / filename, "w", encoding="utf-8") as target, | ||
): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$ git add -p
is your friend to avoid committing unrelated changes.
@@ -179,7 +179,10 @@ def _get_all_reports(self) -> dict: | |||
Client ID: {self.client_id} | |||
""" | |||
logger.debug(message) | |||
return requests.get(reports_url, headers=headers, timeout=20).json() | |||
response = requests.get(reports_url, headers=headers, timeout=20).json() | |||
if response == {"detail": "Forbidden"}: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if response == {"detail": "Forbidden"}: | |
if response.status_code == 401: |
No description provided.