Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update action.yml for features #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update action.yml for features #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 3 additions & 12 deletions action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,8 @@ inputs:
description: 'rpc'
required: true
type: string
pid:
description: 'program PID'
required: true
type: string
pid_env_var:
description: 'program PID env var'
feature:
description: 'Feature to build'
required: true
type: string
ssh_private_key:
Expand Down Expand Up @@ -75,12 +71,7 @@ runs:
- run: chmod +x ~/.cargo/bin/anchor
shell: bash

- name: Set program PID to devnet PID
run: |
echo "${{ inputs.pid_env_var }}=${{ inputs.pid }}" >> $GITHUB_ENV
shell: bash

- name: Build
run: |
anchor build
anchor build --features=${{ inputs.feature }}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enclose the feature input variable in quotes to prevent issues with feature names containing spaces or special characters.

-        anchor build --features=${{ inputs.feature }}
+        anchor build --features="${{ inputs.feature }}"
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
anchor build --features=${{ inputs.feature }}
anchor build --features="${{ inputs.feature }}"

shell: bash