Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slog mains #2

Closed
wants to merge 7 commits into from
Closed

slog mains #2

wants to merge 7 commits into from

Conversation

brianolson
Copy link
Owner

add integration into main()s for slog, set level, output file, log rotation rules, text or json

stack on bluesky-social#858

@bnewbold
Copy link

bnewbold commented Dec 5, 2024

I feel a bit meh about adding logrotate and other complex stuff like that. do we use any go-log functionality other than setting the log level, anywhere in our stack? I think we basically log out to stdout/stderr everywhere, and use other daemons/systems to manage the stream of logs (eg, implement log rotation, shipping to relevant log indexing services, etc).

but I care more about getting the log/slog refactor merged than I do nit-picking around log infra generally.

@brianolson brianolson changed the base branch from bolson/slog to main December 5, 2024 03:45
@brianolson brianolson changed the base branch from main to bolson/slog December 5, 2024 03:46
@brianolson
Copy link
Owner Author

relay works better logging directly to file and the rotation stuff has been exercised in recent gigarelay experiments

@brianolson
Copy link
Owner Author

this is replaced by bluesky-social#866 which is the same stuff but against main after bluesky-social#856 has merged

@brianolson
Copy link
Owner Author

merged as bluesky-social#866

@brianolson brianolson closed this Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants