Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specified flags are not compatible with Solaris Studio C compiler. #149

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

orderthruchaos
Copy link

When using the Solaris Studio C compiler, the specified flags generate errors. This may affect other compilers, but this is at least a starting point.

@lamont-granquist
Copy link

This problem also affects AIX and the xlc compiler.

orderthruchaos referenced this pull request in ffi/ffi Oct 28, 2014
Also, allow compiler flag to be set for older/newer versions of Solaris.

Admittedly, it is a bit of a preemtive strike for later versions.
@orderthruchaos
Copy link
Author

With @lamont-granquist's comment in mind, you may want to remove the condition on RbConfig::CONFIG['host_os'].

@lamont-granquist
Copy link

I'd suggest just using if RbConfig::MAKEFILE_CONFIG['CC'] =~ /gcc|clang/ to protect the gcc-specific flags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants