Remove usage of org.springframework.remoting.support.RemoteExporter #303 #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ter down into AbstractJsonServiceExporter RemoteExporter is deprecated and is now removed from Spring Framework v6+. It was used only to provide service and serviceInterface properties and some related methods. User defined Java services are registered in the Spring MVC using BeanNameUrlHandlerMapping, and RemoteExporter provided only some base functionality for accessing service class and interface. This functionality may be pulled down to AbstractJsonServiceExporter, and this preserves compatibility in existing applications, which use service and serviceInterface properties. Signed-off-by: cyb3r4nt <[email protected]>
…nd mark access methods as deprected RemoteExporter is deprecated and has been removed from Spring Framework starting from v6. This change removes registerTraceInterceptor parameter registration in RemoteExporter. Methods are marked as @deprecated to preserve compile-time compatibility. Signed-off-by: cyb3r4nt <[email protected]>
Signed-off-by: cyb3r4nt <[email protected]>
…n the application context Adds same Spring Context XML configuration as described in the README and verifies that beans are properly registered. Signed-off-by: cyb3r4nt <[email protected]>
|
Any deadline on merging this? |
|
I think Spring Boot 2.x apps will need to bump by November to avoid OSS EOL... |
|
Hi @briandilley, could you help review this PR and release a new version for this? Thanks a lot <3 |
|
Hi @briandilley, Any insight present when you attempt to merge this crucial PR? |
|
Ping @cyb3r4nt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove usage of
org.springframework.remoting.support.RemoteExporter#303RemoteExporterwas used mostly as data holder forserviceandserviceInterfaceproperties.Remoting support was removed from Spring Framework 6 and Spring does not provide this class anymore.
This change moves required
serviceandserviceInterfacefields fromRemoteExporterintoAbstractJsonServiceExporterand removes usage ofRemoteExporter.(See also comment #303 (comment))
Other bean registration logic was not changed.
This new version may fail for the users who inherited from the
AbstractJsonServiceExporterclass or its descendants,and directly use any functionality inherited from
RemoteExporter.I tested this with Spring Framework 6 and there were no class loading related problems in my env.