Pass paramFormats and paramLengths onto libpq #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #52, this passes
paramFormatsandparamLengthsonto libpq, except the parameters are constructed in JavaScript. Includes more extensive tests.Would be happy to add the tests onto #52 if that approach is preferred.
The intent is to fix an inconsistency in node-postgres, where non-native bindings pass buffers as binary parameters, but native bindings (using this library) pass them as strings. Passing
paramFormatsandparamLengthsis currently enough to fix this—if these are passed, libpq correctly detects them as binary parameters (see PostgreSQL fe-exec.c).Thanks for looking into this!