Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cmd): Add build Command to CLI Tool #252

Merged
merged 4 commits into from
Oct 7, 2024
Merged

Conversation

jshlbrd
Copy link
Collaborator

@jshlbrd jshlbrd commented Oct 5, 2024

Description

  • Adds substation build to the CLI tool

Motivation and Context

This replaces the build shell script and follows the conventions of other CLI tool commands (mimicking the go tool).

These readme.com docs need to be updated for the v2.2.0 release:

How Has This Been Tested?

substation build was integration tested for a variety of use cases:

  • Building individual files
  • Building directories
  • Building nested directories

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@jshlbrd jshlbrd marked this pull request as ready for review October 7, 2024 15:10
@jshlbrd jshlbrd requested a review from a team as a code owner October 7, 2024 15:10
Copy link
Contributor

@shellcromancer shellcromancer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only blocking change is on the comment for compileFile 👍

cmd/substation/main.go Outdated Show resolved Hide resolved
cmd/substation/build.go Outdated Show resolved Hide resolved
@jshlbrd jshlbrd requested a review from shellcromancer October 7, 2024 15:47
@jshlbrd jshlbrd merged commit 5ffe528 into main Oct 7, 2024
7 checks passed
@jshlbrd jshlbrd deleted the jshlbrd/feat/cmd-build branch October 7, 2024 16:10
This was referenced Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants