Handle HTTP errors in links #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
locales/en/messages.json
Outdated
| @@ -70,6 +70,7 @@ | |||
| "FILE_TYPE_MUST_BE": "Accepted file type:", | |||
| "FILE_TYPE_NOT_ACCEPTED": "File type not supported", | |||
| "FILES": "Files", | |||
| "FILTERS": "Filters", | |||
There was a problem hiding this comment.
Intstead of Filters I would use Show as a label
| options: {}, | ||
| }, | ||
| }); | ||
| indexing.value = false; |
There was a problem hiding this comment.
after a reindex we should read the indexed document in order to see if a document has been actually indexed/updated or not
We should call GET /api/brevia/index/{collection_id}/{document_id} or GET /api/brevia/index/{collection_id}/document_metadata?document_id={document_id}
A user feedback is then needed + change of state (like http_error removal) if something has changed
stefanorosanelli
changed the title
stefanorosanelli
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aggiunge la gestione degli errori nella parte links del chatbot.
http_errorvalorizzato, allora si visualizza con uno sfondo arancione ed il messaggio di errorehttp_errorcompare, al posto del pulsante dei metadati, un tasto per reindicizzare ( che richiamaPOST /api/brevia/index/link)