Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slash in the end of laravel root path and namespacing function #140

Conversation

alustau
Copy link
Contributor

@alustau alustau commented Nov 13, 2023

No description provided.

@alustau alustau force-pushed the implement-custom-vendor-placement branch from 96f216c to 48df7cf Compare November 13, 2023 16:10
@alustau alustau force-pushed the implement-custom-vendor-placement branch from 48df7cf to ad2c698 Compare November 13, 2023 16:16
@alustau alustau changed the title Add slash in the end of laravel home path when use realpath Add slash in the end of laravel root path when use realpath Nov 13, 2023
@alustau alustau changed the title Add slash in the end of laravel root path when use realpath Add slash in the end of laravel root path and namespacing function Nov 13, 2023
@mnapoli
Copy link
Member

mnapoli commented Nov 14, 2023

How does this relate to #131?

If it replaces it, can we preserve the commits of #131? (to preserve authorship)

@deleugpn
Copy link
Member

sorry, I was suppose to have merged this on my branch 2 weeks ago 🤦

@deleugpn deleugpn merged commit 727e4f0 into brefphp:custom-vendor-placement Nov 24, 2023
12 checks passed
@mnapoli
Copy link
Member

mnapoli commented Nov 24, 2023

Yeah my bad, I did not read the target PR 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants