fix: resolve Laravel home using __DIR__ #130
Conversation
src/bref-init.php
Outdated
| @@ -7,6 +7,8 @@ | |||
| use Bref\LaravelBridge\StorageDirectories; | |||
|
|
|||
| Bref::beforeStartup(static function () { | |||
| $laravelHome = __DIR__ . '/../../../../'; | |||
There was a problem hiding this comment.
This is way to ambitious. Use a constant or add a custom ENV variable instead.
There was a problem hiding this comment.
I kinda prefer this over more configuration options tbh...
There was a problem hiding this comment.
What do you mean by "Use a constant"? This at the top?
define('LARAVEL_HOME', __DIR__ . '/../../../../');
| @@ -7,6 +7,8 @@ | |||
| use Bref\LaravelBridge\StorageDirectories; | |||
|
|
|||
| Bref::beforeStartup(static function () { | |||
| $laravelHome = $_ENV['LARAVEL_HOME'] ?? __DIR__ . '/../../../../'; | |||
There was a problem hiding this comment.
Please default to LAMBA_ROOT_TASK.
|
I just opened #131 as an alternative to this and explained why I preferred the previous approach. |
There was a problem hiding this comment.
I'm tagging this with request changes so that we can better discuss the alternative approach on #131 before merging. If we still opt for this option, I'd like to get the HandlerResolver also implemented to solve loading namespaced Handlers with custom vendor.
src/bref-init.php
Outdated
| @@ -7,6 +7,8 @@ | |||
| use Bref\LaravelBridge\StorageDirectories; | |||
|
|
|||
| Bref::beforeStartup(static function () { | |||
| $laravelHome = $_ENV['LAMBA_ROOT_TASK'] ?? __DIR__ . '/../../../../'; | |||
There was a problem hiding this comment.
This will never work because LAMBDA_ROOT_TASK is always defined so the __DIR__ alternative here will never be executed, which will make it dead code
There was a problem hiding this comment.
Ah, I thought it's just the preferred name of the variable 😉 I renamed it temporarily and wait for #131 instead then.
|
#131 has been merged and should address this, so I'm going to close this one. If the author, or anybody else, feels differently, please feel free to open an issue or another PR for us to discuss it further! |
When using a mono repository, the Laravel folder is not the root folder. Hence, we cannot simply take the Lambda Root and expect Laravel files to be present. Instead, this PR uses the current directory of the script and just finds the Laravel files relatively via going up the directory tree.