Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace a bunch of http links with https #1631

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Replace a bunch of http links with https #1631

merged 1 commit into from
Sep 11, 2023

Conversation

GrahamCampbell
Copy link
Contributor

No description provided.

@GrahamCampbell
Copy link
Contributor Author

@mnapoli 👋

@mnapoli
Copy link
Member

mnapoli commented Sep 11, 2023

Hey, I was looking at this but I actually don't really want to merge this 😬

I'm rewriting the whole docs in #1596, changing this on master will create unnecessary conflicts. I'd rather avoid this on master (changing this to target #1596 could work though)

@GrahamCampbell
Copy link
Contributor Author

Can we merge just the two changes from tests for now?

@mnapoli
Copy link
Member

mnapoli commented Sep 11, 2023

Yes we can

@GrahamCampbell
Copy link
Contributor Author

Done.

@mnapoli mnapoli merged commit 122143b into brefphp:master Sep 11, 2023
@GrahamCampbell GrahamCampbell deleted the https branch September 11, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GrahamCampbell @mnapoli