Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flutter 3.22 - Dependencies breaking build #890

Merged
merged 3 commits into from
May 14, 2024
Merged

Conversation

erdemyerebasmaz
Copy link
Collaborator

@erdemyerebasmaz erdemyerebasmaz commented May 14, 2024

Updated dependencies that are not compatible with Flutter 3.22.

  • Forked drag_and_drop_list and addressed issues here.
    • Note: This plugin is no longer maintained.
  • Addressed breaking changes on our fork of flutter_typeahead here.

@erdemyerebasmaz erdemyerebasmaz changed the title Flutter 3.22 - Dependencies Flutter 3.22 - Dependencies breaking build May 14, 2024
Copy link
Contributor

@dangeross dangeross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. LGTM

@dangeross
Copy link
Contributor

Tested again. I get this error on enter after filling mnemonic field 7 - 12

Another exception was thrown: RangeError (index): Invalid value: Not in inclusive range 0..11: 12
flutter: [Logger] {SEVERE} (2024-05-14T14:28:54.189355Z) : RangeError (index): Invalid value: Not in inclusive range 0..11: 12 -- FlutterError
══╡ EXCEPTION CAUGHT BY WIDGETS ╞════════════════════════════════
The following RangeError was thrown while calling onSubmitted for
TextInputAction.next:
RangeError (index): Invalid value: Not in inclusive range 0..11:
12

When the exception was thrown, this was the stack:
#0      List.[] (dart:core-patch/growable_array.dart:264:36)
#1      RestoreFormPageState._onSelected (package:c_breez/routes/initial_walkthrough/mnemonics/widgets/restore_form.dart:123:34)
#2      RestoreFormPageState.build.<anonymous closure>.<anonymous closure>.<anonymous closure> (package:c_breez/routes/initial_walkthrough/mnemonics/widgets/restore_form.dart:57:47)
#3      EditableTextState._finalizeEditing (package:flutter/src/widgets/editable_text.dart:3449:18)
#4      EditableTextState.performAction (package<…>

@dangeross dangeross self-requested a review May 14, 2024 14:32
@erdemyerebasmaz
Copy link
Collaborator Author

erdemyerebasmaz commented May 14, 2024

Tested again. I get this error on enter after filling mnemonic field 7 - 12

Another exception was thrown: RangeError (index): Invalid value: Not in inclusive range 0..11: 12
flutter: [Logger] {SEVERE} (2024-05-14T14:28:54.189355Z) : RangeError (index): Invalid value: Not in inclusive range 0..11: 12 -- FlutterError
══╡ EXCEPTION CAUGHT BY WIDGETS ╞════════════════════════════════
The following RangeError was thrown while calling onSubmitted for
TextInputAction.next:
RangeError (index): Invalid value: Not in inclusive range 0..11:
12

When the exception was thrown, this was the stack:
#0      List.[] (dart:core-patch/growable_array.dart:264:36)
#1      RestoreFormPageState._onSelected (package:c_breez/routes/initial_walkthrough/mnemonics/widgets/restore_form.dart:123:34)
#2      RestoreFormPageState.build.<anonymous closure>.<anonymous closure>.<anonymous closure> (package:c_breez/routes/initial_walkthrough/mnemonics/widgets/restore_form.dart:57:47)
#3      EditableTextState._finalizeEditing (package:flutter/src/widgets/editable_text.dart:3449:18)
#4      EditableTextState.performAction (package<…>

Thanks, I'm aware of the issue & working on a solution that makes onSelected & onFieldSubmitted behave similarly.

Edit: Addressed here e0eadb2

@erdemyerebasmaz
Copy link
Collaborator Author

@dangeross reverted upgrading flutter_typeahead to latest on pub.dev and I've only addressed breaking changes on our fork.

Prevent predictive text
@erdemyerebasmaz erdemyerebasmaz merged commit 6d44b7e into main May 14, 2024
1 check passed
@erdemyerebasmaz erdemyerebasmaz deleted the flutter-3.22 branch May 14, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants