Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doesn't show the fiat amount when the sats balance is zero #674

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Doesn't show the fiat amount when the sats balance is zero #674

merged 1 commit into from
Oct 11, 2023

Conversation

ademar111190
Copy link
Collaborator

Hide the fiat amount showed at home page if the sats amount is zero

Screenshots
Before After
Screenshot_20231011_101904-min Screenshot_20231011_102656-min

How to test

  • Create a new wallet or get wallet without any sats
    • It should not show the fiat value
  • Using a wallet that has sats
    • It should show the fiat value

@ademar111190 ademar111190 requested a review from a team October 11, 2023 13:35
@ademar111190 ademar111190 self-assigned this Oct 11, 2023
ubbabeck
ubbabeck approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@ubbabeck ubbabeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 👍

@ademar111190 ademar111190 merged commit f63e7da into main Oct 11, 2023
1 check passed
@ademar111190 ademar111190 deleted the aa/fix-fiat-amount-on-0-sats branch October 11, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ubbabeck ubbabeck ubbabeck approved these changes

Assignees

@ademar111190 ademar111190

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ademar111190 @ubbabeck