Add fee params arg to createInvoice #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roeierez
requested changes
Oct 9, 2023
| @@ -198,9 +198,13 @@ class CreateInvoicePageState extends State<CreateInvoicePage> { | |||
| final accountBloc = context.read<AccountBloc>(); | |||
| final currencyBloc = context.read<CurrencyBloc>(); | |||
|
|
|||
| final lspInfo = context.read<LSPBloc>().state?.lspInfo; | |||
| final cheapestFeeParams = lspInfo?.openingFeeParamsList.values.first; | |||
There was a problem hiding this comment.
This seems to work but I think it is better to have one stream of the LSP that wraps the build method and pass the fee params explicitly to this _createInvoice function.
This fee params also should be passed to the ReceivableBTCBox.
This way we are sure that the same fee params that are displayed to the user are sent to the create invoice and it is trivial to understand that from the code.
There was a problem hiding this comment.
we can use context.watch which listens to changes to ().state. Though we need to define it earlier in the build method so that it rebuilds if there are any changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the cheapest known feerate as argument to
createInvoice.Fixes #643