-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trigger send to BTC address flow when camera reads a BTC address #665
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 😃
@ademar111190 This will trigger the onchain page also when the bitcoin address is copied to the clipboard right? |
Good catch,
Good catch I forgot about this when reviewing. We only want to push the reverse_swap page when scanning btc addresses and not when it is in the clipboard. |
That is a good point, and it is a difference in behavior that may appear in the future as well. When X is inputed, do Y if the source is Z. |
296cc9a
to
e7451d7
Compare
I edit the PR with the following changes:
|
9d9aa13
to
ba275c5
Compare
I don't know why the CI is not passing, the error:
but running locally I got no diff:
I've checked account_bloc.dart and create_invoice_page.dart both are okay (I even manually edit the comments to make sure it is under 110 lines) |
ba275c5
to
eea9199
Compare
Fixes: #570
How to test