Verify seed phrase #664
Merged
Verify seed phrase #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roeierez
requested changes
Oct 9, 2023
| @@ -162,7 +162,10 @@ class InitialWalkthroughPageState extends State<InitialWalkthroughPage> | |||
|
|
|||
| final themeProvider = ThemeProvider.controllerOf(context); | |||
| try { | |||
| await accountBloc.connect(mnemonic: mnemonic ?? bip39.generateMnemonic(strength: 128)); | |||
| await accountBloc.connect( | |||
| mnemonic: mnemonic ?? bip39.generateMnemonic(strength: 128), | |||
There was a problem hiding this comment.
How about pass null in the mnemonics in restore case and then we don't need the restored flag?
There was a problem hiding this comment.
Account bloc uses the null case already: https://github.com/breez/c-breez/pull/664/files#diff-5dbe6ee35eb95a61a99689c83031840c5e21fc8f6a0f24b8b42ecbc2a87ab16bR54 when it is null, it doesn't change the current state of the validation status.
So, in order to use null instead of the boolean flag, I need to change how the bloc is started, from if (!state.initial) connect(); to something like if (!state.initial) init(); and adding this init method.
Let me know if you prefer this way Roei.
roeierez
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #647
How to test
Flow 1 (new wallets)
Flow 2 (restored wallets)