Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of LNURLw response types #660

Merged
merged 3 commits into from
Oct 7, 2023
Merged

Fix handling of LNURLw response types #660

merged 3 commits into from
Oct 7, 2023

Conversation

ok300
Copy link
Collaborator

@ok300 ok300 commented Oct 6, 2023

Fixes #655

erdemyerebasmaz
erdemyerebasmaz previously approved these changes Oct 6, 2023
@erdemyerebasmaz erdemyerebasmaz requested review from erdemyerebasmaz and ubbabeck and removed request for erdemyerebasmaz and ubbabeck October 6, 2023 20:42
@erdemyerebasmaz erdemyerebasmaz dismissed their stale review October 6, 2023 20:43

Need more context

Copy link
Collaborator

@erdemyerebasmaz erdemyerebasmaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with 2 NIT comments

@ok300 ok300 marked this pull request as ready for review October 7, 2023 06:02
@ok300
Copy link
Collaborator Author

ok300 commented Oct 7, 2023

Thanks @erdemyerebasmaz !

@ok300 ok300 merged commit 32d95ab into main Oct 7, 2023
1 check passed
@ok300 ok300 deleted the ok300-fix-lnurl-w branch October 7, 2023 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LNURL - Withdraw error message
2 participants