-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
let user specify exemptfee #636
Conversation
@ubbabeck I don't see it on your screenshot. am I missing something? |
I used the same text as we have in breezmobile, should we change it to |
_log.v("Payments override fetched: enabled: $enabled, proportional: $proportional"); | ||
final excemptFeeMsat = await _preferences.getPaymentOptionsExemptFee(); | ||
_log.v( | ||
"Payments override fetched: enabled: $enabled, proportional: $proportional, excemptFeeMsat: $excemptFeeMsat"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo in excemptFeeMsat
should be exemptFeeMsat
.
There also another one in file name, please address every occurange.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ubbabeck there's one more thing remaining, the file name :)
lib/routes/payment_options/widget/excempt_fee_widget.dart
Edit: Oh, it exists on other files as well... Please use your IDE's search & replace function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason this word tripped me up big time, believe all typos have been removed now. Except the remote branch name...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
About PR
Implements #634
how it looks