Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let user specify exemptfee #636

Merged
merged 3 commits into from
Sep 28, 2023
Merged

let user specify exemptfee #636

merged 3 commits into from
Sep 28, 2023

Conversation

ubbabeck
Copy link
Contributor

About PR

Implements #634

how it looks

set_exemptfee

@ademar111190
Copy link
Collaborator

@ubbabeck I don't see it on your screenshot. am I missing something?

@ubbabeck
Copy link
Contributor Author

@ubbabeck I don't see it on your screenshot. am I missing something?

I used the same text as we have in breezmobile, should we change it to Exempt Fee in sats instead ?

_log.v("Payments override fetched: enabled: $enabled, proportional: $proportional");
final excemptFeeMsat = await _preferences.getPaymentOptionsExemptFee();
_log.v(
"Payments override fetched: enabled: $enabled, proportional: $proportional, excemptFeeMsat: $excemptFeeMsat");
Copy link
Collaborator

@erdemyerebasmaz erdemyerebasmaz Sep 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in excemptFeeMsat
should be exemptFeeMsat.

There also another one in file name, please address every occurange.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed 😃

Copy link
Collaborator

@erdemyerebasmaz erdemyerebasmaz Sep 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ubbabeck there's one more thing remaining, the file name :)
lib/routes/payment_options/widget/excempt_fee_widget.dart

Edit: Oh, it exists on other files as well... Please use your IDE's search & replace function.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason this word tripped me up big time, believe all typos have been removed now. Except the remote branch name...

@ubbabeck
Copy link
Contributor Author

Updated translations

exempt_fee

@JssDWt JssDWt changed the title let user spesify exemptfee let user specify exemptfee Sep 28, 2023
Copy link
Collaborator

@erdemyerebasmaz erdemyerebasmaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erdemyerebasmaz erdemyerebasmaz merged commit b11846a into main Sep 28, 2023
@erdemyerebasmaz erdemyerebasmaz deleted the set-excemptfee branch November 16, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants