Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove pasting handling #633

Merged
merged 2 commits into from
Sep 25, 2023
Merged

remove pasting handling #633

merged 2 commits into from
Sep 25, 2023

Conversation

ubbabeck
Copy link
Contributor

This pr removes the pasting logic of the send_options_bottom_sheet.dart to mimic the behaviour of breezmobile.

I believe this can be removed since the inputhandler handles the data if the user has something in their clipboard and in my opinion the UX is also better now. The user might want to manually write in an lighting address while having an invoice in the clipboard.

@ubbabeck ubbabeck self-assigned this Sep 22, 2023
@ubbabeck ubbabeck linked an issue Sep 22, 2023 that may be closed by this pull request
@ademar111190
Copy link
Collaborator

@ubbabeck do you mind sharing a before/after video? because it is not clear to me what is the difference in the UX you got by these changes.

@ubbabeck
Copy link
Contributor Author

ubbabeck commented Sep 22, 2023

Here is an example of how they differ @ademar111190

New flow

new_paste_flow.mov

Old flow

old_paste_flow.mov

@ubbabeck ubbabeck force-pushed the 609-multiple-pasting branch from a8e12ed to 5bf89bc Compare September 25, 2023 08:42
Copy link
Collaborator

@erdemyerebasmaz erdemyerebasmaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@erdemyerebasmaz erdemyerebasmaz merged commit 077d86b into main Sep 25, 2023
1 check passed
@erdemyerebasmaz erdemyerebasmaz deleted the 609-multiple-pasting branch September 27, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Paste invoice or ID - Multiple pasting
3 participants