Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autocomplete on restore form #606

Closed
wants to merge 3 commits into from
Closed

Autocomplete on restore form #606

wants to merge 3 commits into from

Conversation

erdemyerebasmaz
Copy link
Collaborator

This PR addresses #505

Applies the behavior described in #505 (comment):

Autocompleting the word after typing four letters(as BIP39 words are uniquely identified by the first four letters) without the need to click on the word of autocomplete result.

For example: > qua

quality
quantum
quarter

typing the fourth letter should fill the field with the matching value then focus on the next input field.

@erdemyerebasmaz erdemyerebasmaz added this to the v0.1.1-alpha milestone Jul 17, 2023
@erdemyerebasmaz erdemyerebasmaz linked an issue Jul 17, 2023 that may be closed by this pull request
No autocomplete on restore seed, autocomplete #505
Open
roeierez
roeierez requested changes Jul 17, 2023
View reviewed changes
Copy link
Member

@roeierez roeierez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than one small suggestion, LGTM

lib/routes/initial_walkthrough/mnemonics/widgets/restore_form.dart Outdated
if (pattern.length == 4 && suggestionList.isNotEmpty) {
_selectSuggestion(suggestionList.first, itemIndex);
return List.empty();
}
return suggestionList.isNotEmpty ? suggestionList : List.empty();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return suggestionList.isNotEmpty ? suggestionList : List.empty();
return suggestionList

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with this. Did not autocomplete or fill out the word.

ubbabeck
ubbabeck reviewed Jul 17, 2023
View reviewed changes
Copy link
Contributor

@ubbabeck ubbabeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with both your example and the suggested edit, but did not fill in the word.

lib/routes/initial_walkthrough/mnemonics/widgets/restore_form.dart Outdated
if (pattern.length == 4 && suggestionList.isNotEmpty) {
_selectSuggestion(suggestionList.first, itemIndex);
return List.empty();
}
return suggestionList.isNotEmpty ? suggestionList : List.empty();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with this. Did not autocomplete or fill out the word.

@erdemyerebasmaz
Copy link
Collaborator Author

erdemyerebasmaz commented Jul 17, 2023 •
edited
Loading

Tested with both your example and the suggested edit, but did not fill in the word.

Thanks Ruben. There's probably another underlying issue with how TypeAheadFormField's callback's work. Keeping this as draft till I get the chance to test this.

@erdemyerebasmaz erdemyerebasmaz force-pushed the auto_complete_suggestions branch from e836655 to 20a70a4 Compare September 25, 2023 08:40
@roeierez
Copy link
Member

Is it still relevant @erdemyerebasmaz ?

@erdemyerebasmaz
Copy link
Collaborator Author

erdemyerebasmaz commented Sep 28, 2023 •
edited
Loading

Is it still relevant @erdemyerebasmaz ?

Yes, but haven't had a chance to reevaluate after Ruben's findings. This is a low priority enhancement.

@erdemyerebasmaz erdemyerebasmaz added enhancement New feature or request low priority labels Sep 28, 2023
@erdemyerebasmaz erdemyerebasmaz force-pushed the auto_complete_suggestions branch from 20a70a4 to 3d522e2 Compare October 4, 2023 20:07
@erdemyerebasmaz
Copy link
Collaborator Author

The autocomplete is functional but it has a lot of issues if you try to change/delete the autocompleted word at the moment.

It works really well if you get everything right on the first try but we can't rely on that :) Postponing this.

@erdemyerebasmaz erdemyerebasmaz removed this from the v0.1.1-alpha milestone Oct 4, 2023
@erdemyerebasmaz erdemyerebasmaz deleted the auto_complete_suggestions branch November 3, 2023 16:04
@erdemyerebasmaz erdemyerebasmaz restored the auto_complete_suggestions branch November 3, 2023 16:04
@erdemyerebasmaz erdemyerebasmaz deleted the auto_complete_suggestions branch November 16, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ubbabeck ubbabeck ubbabeck left review comments

@roeierez roeierez roeierez requested changes

@ademar111190 ademar111190 Awaiting requested review from ademar111190

@ok300 ok300 Awaiting requested review from ok300

Assignees

@ubbabeck ubbabeck

Labels
enhancement New feature or request low priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No autocomplete on restore seed, autocomplete
3 participants
@erdemyerebasmaz @roeierez @ubbabeck