Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mandatory API key checks #639

Open
wants to merge 3 commits into
base: savage-discount-ct
Choose a base branch
from

Conversation

hydra-yse
Copy link
Member

@hydra-yse hydra-yse commented Jan 4, 2025

Built on top of #637
This PR:

  • Makes the real-time sync service optional (depending on the presence of sync_service_url) as follows:
    • Set and equal to BREEZ_SYNC_SERVICE_URL: Check for API key
    • Set and different from BREEZ_SYNC_SERVICE_URL: Use without API key
    • Not set: Disable the sync service
  • Conditionally calls rt-sync commit methods to avoid cluttering of the db when the sync service is not active
  • Skips the initial validate_api_key call unless it is set in the config

This should complete all the requirements for #554, except for the swapper proxy changes & fiat api.

@hydra-yse hydra-yse self-assigned this Jan 4, 2025
@hydra-yse hydra-yse force-pushed the yse-optional-api-key branch 2 times, most recently from cda3ef0 to b5b7d78 Compare January 4, 2025 18:49
@roeierez
Copy link
Member

roeierez commented Jan 6, 2025

@hydra-yse this needs rebase on top of the base branch.

@roeierez roeierez modified the milestone: v0.6.0 Jan 6, 2025
@hydra-yse hydra-yse changed the base branch from savage-discount-ct to main January 8, 2025 14:28
@hydra-yse hydra-yse changed the base branch from main to savage-discount-ct January 8, 2025 14:29
@hydra-yse hydra-yse force-pushed the yse-optional-api-key branch from b5b7d78 to 1fc334f Compare January 8, 2025 14:54
@roeierez roeierez added this to the Next Release milestone Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants