Add payment expiry #622

dangeross · 2024-12-20T17:52:31Z

This PR:

exposes the liquid/bitcoin_expiration_blockheight field in the Lightning/Bitcoin type payment details, based on the swap's timeout_block_height field
changes the GetInfoResponse structure to include two fields only, the wallet information (pubkey, fingerprint etc.) and the blockchain information (tips), so that clients may compare the current tip to the payment's expiration block height

Fixes #415

lib/core/src/persist/migrations.rs

roeierez

Looks good. Some small comments.

lib/core/src/sync/model/data.rs

lib/core/src/recover/recoverer.rs

lib/core/src/model.rs

lib/core/src/recover/recoverer.rs

lib/core/src/sdk.rs

lib/core/src/model.rs

dangeross

The tests and Notfication Plugin also need updating to accommodate the get_info() response changes

lib/bindings/langs/swift/Sources/BreezSDKLiquid/Task/SwapUpdated.swift

lib/core/src/model.rs

lib/core/src/recover/recoverer.rs

lib/core/src/sync/model/data.rs

lib/core/src/chain/liquid.rs

danielgranhao

Other than @dangeross's comments, utACK

lib/core/src/persist/cache.rs

taken from #622 (review)

roeierez

LGTM

lib/core/src/model.rs

taken from #622 (review)

dangeross · 2025-01-04T13:55:45Z

Seems like the Info not found error is causing the bindings tests to fail. I would check that get_info() correctly correctly initialises the wallet info cache if there is no cache set when the fn is called

dangeross

LGTM. Just needs a rebase

We should note its a breaking change in the release @roeierez

fix(clippy): use `clone_if_set` for sync destination fix: revert rebase changes feat: add `expiration_block` to payment details feat: add `blockchain_details` to `GetInfoResponse` fix: rename fields to `<chain>_expiry_blockheight` fix: update `GetInfoResponse` structure fix: address review comments taken from #622 (review) fix: use better error handling for get_info fix: bindings tests fix: ensure blockchain_info is optional in query

roeierez · 2025-01-06T12:04:37Z

@hydra-yse we need a following PR in misty breez and change the docs accordingly. Let's hold the merge at least until we have the misty breez change which should be straight forward otherwise the misty build will be broken.

fix(clippy): use `clone_if_set` for sync destination fix: revert rebase changes feat: add `expiration_block` to payment details feat: add `blockchain_details` to `GetInfoResponse` fix: rename fields to `<chain>_expiry_blockheight` fix: update `GetInfoResponse` structure fix: address review comments taken from #622 (review) fix: use better error handling for get_info fix: bindings tests fix: ensure blockchain_info is optional in query

dangeross force-pushed the savage-payment-expiry branch from 75c048f to 4dbfe3b Compare December 20, 2024 18:08

roeierez requested changes Dec 22, 2024

View reviewed changes

lib/core/src/persist/migrations.rs Outdated Show resolved Hide resolved

roeierez requested changes Dec 22, 2024

View reviewed changes

lib/core/src/sync/model/data.rs Outdated Show resolved Hide resolved

lib/core/src/recover/recoverer.rs Outdated Show resolved Hide resolved

roeierez added this to the v0.6..0 milestone Dec 23, 2024

dangeross changed the base branch from savage-lnurl-payment-details to rt-sync December 23, 2024 11:57

hydra-yse force-pushed the rt-sync branch from 34bc791 to 422ae39 Compare December 24, 2024 09:26

hydra-yse force-pushed the savage-payment-expiry branch from 4dbfe3b to 944211e Compare December 24, 2024 14:53

hydra-yse changed the base branch from rt-sync to main December 24, 2024 14:53

hydra-yse requested a review from roeierez December 25, 2024 19:28

dangeross commented Dec 25, 2024

View reviewed changes

lib/core/src/model.rs Outdated Show resolved Hide resolved

roeierez requested changes Dec 25, 2024

View reviewed changes

lib/core/src/recover/recoverer.rs Outdated Show resolved Hide resolved

hydra-yse force-pushed the savage-payment-expiry branch 2 times, most recently from 13a4b72 to 812b31f Compare December 27, 2024 11:09

hydra-yse requested a review from roeierez December 27, 2024 11:13

hydra-yse force-pushed the savage-payment-expiry branch from 812b31f to 35f41bb Compare December 27, 2024 11:15

hydra-yse marked this pull request as ready for review December 27, 2024 11:16

roeierez requested changes Dec 27, 2024

View reviewed changes

lib/core/src/sdk.rs Outdated Show resolved Hide resolved

lib/core/src/model.rs Show resolved Hide resolved

danielgranhao reviewed Dec 27, 2024

View reviewed changes

lib/core/src/model.rs Outdated Show resolved Hide resolved

lib/core/src/model.rs Outdated Show resolved Hide resolved

roeierez assigned hydra-yse Dec 29, 2024

hydra-yse requested review from danielgranhao and roeierez December 30, 2024 04:54

hydra-yse force-pushed the savage-payment-expiry branch from 1db033b to a081d15 Compare December 30, 2024 10:44

dangeross commented Dec 30, 2024

View reviewed changes

danielgranhao reviewed Dec 31, 2024

View reviewed changes

roeierez requested changes Dec 31, 2024

View reviewed changes

lib/core/src/persist/cache.rs Outdated Show resolved Hide resolved

hydra-yse added a commit that referenced this pull request Dec 31, 2024

fix: address review comments

1db411d

taken from #622 (review)

hydra-yse force-pushed the savage-payment-expiry branch from a081d15 to 1db411d Compare December 31, 2024 12:09

hydra-yse added a commit that referenced this pull request Jan 2, 2025

fix: address review comments

617a070

taken from #622 (review)

hydra-yse force-pushed the savage-payment-expiry branch from 1db411d to 617a070 Compare January 2, 2025 08:19

hydra-yse requested a review from roeierez January 2, 2025 08:44

hydra-yse requested a review from danielgranhao January 2, 2025 08:45

hydra-yse force-pushed the savage-payment-expiry branch 2 times, most recently from a609502 to e9e9c6b Compare January 2, 2025 09:28

roeierez approved these changes Jan 2, 2025

View reviewed changes

dangeross commented Jan 2, 2025

View reviewed changes

lib/core/src/model.rs Outdated Show resolved Hide resolved

lib/core/src/model.rs Outdated Show resolved Hide resolved

lib/core/src/model.rs Outdated Show resolved Hide resolved

danielgranhao reviewed Jan 2, 2025

View reviewed changes

lib/core/src/model.rs Outdated Show resolved Hide resolved

hydra-yse added a commit that referenced this pull request Jan 4, 2025

fix: address review comments

2bcb97c

taken from #622 (review)

hydra-yse force-pushed the savage-payment-expiry branch from e9e9c6b to 6ddddb1 Compare January 4, 2025 00:47

hydra-yse requested a review from danielgranhao January 4, 2025 00:48

dangeross commented Jan 6, 2025

View reviewed changes

hydra-yse force-pushed the savage-payment-expiry branch from e3c89d5 to c74d8f0 Compare January 6, 2025 10:32

danielgranhao approved these changes Jan 6, 2025

View reviewed changes

hydra-yse added a commit to breez/misty-breez that referenced this pull request Jan 7, 2025

feat: reflect changes from breez/breez-sdk-liquid#622

c3f2d25

hydra-yse added a commit to breez/misty-breez that referenced this pull request Jan 7, 2025

feat: reflect changes from breez/breez-sdk-liquid#622

59ee156

hydra-yse mentioned this pull request Jan 7, 2025

Multi-asset send/receive #645

Open

3 tasks

hydra-yse force-pushed the savage-payment-expiry branch from c74d8f0 to 287746d Compare January 7, 2025 23:42

hydra-yse merged commit 66810ec into main Jan 8, 2025
9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add payment expiry #622

Add payment expiry #622

dangeross commented Dec 20, 2024 •

edited by hydra-yse

Loading

roeierez left a comment

dangeross left a comment

danielgranhao left a comment

roeierez left a comment

dangeross commented Jan 4, 2025 •

edited

Loading

dangeross left a comment

roeierez commented Jan 6, 2025

Add payment expiry #622

Add payment expiry #622

Conversation

dangeross commented Dec 20, 2024 • edited by hydra-yse Loading

roeierez left a comment

Choose a reason for hiding this comment

dangeross left a comment

Choose a reason for hiding this comment

danielgranhao left a comment

Choose a reason for hiding this comment

roeierez left a comment

Choose a reason for hiding this comment

dangeross commented Jan 4, 2025 • edited Loading

dangeross left a comment

Choose a reason for hiding this comment

roeierez commented Jan 6, 2025

dangeross commented Dec 20, 2024 •

edited by hydra-yse

Loading

dangeross commented Jan 4, 2025 •

edited

Loading