fix liquid pending timestamp #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dangeross
reviewed
Dec 16, 2024
lib/core/src/persist/mod.rs
Outdated
| @@ -268,7 +268,7 @@ impl Persister { | |||
| ptx.tx_id NOT IN (SELECT refund_tx_id FROM chain_swaps WHERE refund_tx_id NOT NULL) | |||
| AND {} | |||
| ORDER BY -- Order by swap creation time or tx timestamp (in case of direct tx) | |||
| COALESCE(rs.created_at, ss.created_at, cs.created_at, ptx.timestamp) DESC | |||
| COALESCE(rs.created_at, ss.created_at, cs.created_at, ptx.timestamp, strftime('%s', 'now')) DESC | |||
There was a problem hiding this comment.
Would it make sense to store the "seen" time (current time) in the db in this case if there is no tx timestamp? Otherwise won't these payments bubble up the payment list
edit: maybe it isn't a bad thing as the eventual tx timestamp will be later anyway
There was a problem hiding this comment.
Makes sense but I will need to make sure we don't override the timestamp as we are doing "insert or replace" for tx_data.
I will take a look.
hydra-yse
approved these changes
Dec 17, 2024
dangeross
approved these changes
Dec 17, 2024
hydra-yse
pushed a commit
that referenced
this pull request
Dec 24, 2024
fix liquid panding timestamp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR pending liquid transactions that were synced were shown at the bottom of the list payments.
This is because their timestamp was null as there was no swap and the transactions was in the mempool.
Now it fallbacks to the current timestamp for pending transaction.
fixed #611