Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zero-amount quote get balance retry #603

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Conversation

dangeross
Copy link
Collaborator

@dangeross dangeross commented Dec 13, 2024

This PR improves the robustness of handling the quote validation by retrying to get the script balance in case the electrum server has not seen the tx yet.

  • Adds retries to getting the user lockup script balance when validating the zero-amount chain swap server lockup quote
  • Uses non-blocking sleep when retying

Fixes #601

Copy link
Contributor

@danielgranhao danielgranhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dangeross dangeross merged commit e3fa3d6 into main Dec 13, 2024
8 checks passed
@dangeross dangeross deleted the savage-zero-amount-retry branch December 13, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zero-amount swap fails if unconfirmed script balance is zero
3 participants