Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Real-time Sync: fix swap update flow #600

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

hydra-yse
Copy link
Member

Note: Instead of ON CONFLICT DO UPDATE SET I've opted for ON CONFLICT DO NOTHING followed by a secondary statement where we selectively update the fields of interest (just like it was previously)

@hydra-yse hydra-yse self-assigned this Dec 12, 2024
Copy link
Collaborator

@dangeross dangeross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Makes sense considering there is already an UPDATE statement in most cases

Copy link
Member

@roeierez roeierez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roeierez roeierez merged commit 715075b into rt-sync Dec 13, 2024
9 checks passed
hydra-yse pushed a commit that referenced this pull request Dec 13, 2024
Real-time Sync: fix swap update flow
hydra-yse pushed a commit that referenced this pull request Dec 14, 2024
Real-time Sync: fix swap update flow
hydra-yse pushed a commit that referenced this pull request Dec 24, 2024
Real-time Sync: fix swap update flow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants