Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

External input parsing #597

Merged
merged 2 commits into from
Dec 12, 2024
Merged

External input parsing #597

merged 2 commits into from
Dec 12, 2024

Conversation

danielgranhao
Copy link
Contributor

@danielgranhao danielgranhao commented Dec 11, 2024 •
edited
Loading

Addresses #535.

TODO:

  • Fix bindings
  • Docs

@danielgranhao danielgranhao changed the title Implement external input parsing External input parsing Dec 11, 2024
@danielgranhao
Copy link
Contributor Author

I'm currently moving the external parsing logic to sdk-common.

@danielgranhao
Copy link
Contributor Author

I'm currently moving the external parsing logic to sdk-common.

breez/breez-sdk-greenlight#1143

@danielgranhao danielgranhao force-pushed the external-input-parsing branch 2 times, most recently from 6d13f25 to 0bb5bf1 Compare December 11, 2024 17:46
@danielgranhao danielgranhao marked this pull request as ready for review December 11, 2024 17:54
@dangeross
Copy link
Collaborator

There are some docs here on how to regenerate the React Native bindings:
https://github.com/breez/breez-sdk-liquid/blob/main/packages/react-native/DEVELOPING.md#prerequisites
Here are more specific versions needed to be installed locally to match the CI:

[email protected]
[email protected]
[email protected]
[email protected]
[email protected]

After running make init in the packages/react-native dir, you only need to run make react-native to regenerate the bindings

dangeross
dangeross reviewed Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@dangeross dangeross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if the external input parsers could be set in the Config and passed during the connect(). Do you see that they could be changed during the life of the SDK instance?

@danielgranhao
Copy link
Contributor Author

I'm wondering if the external input parsers could be set in the Config and passed during the connect(). Do you see that they could be changed during the life of the SDK instance?

@dangeross Hm.. Indeed, I don't see that need. Using the config LGTM. Wdyt @roeierez?

@roeierez
Copy link
Member

I'm wondering if the external input parsers could be set in the Config and passed during the connect(). Do you see that they could be changed during the life of the SDK instance?

@dangeross Hm.. Indeed, I don't see that need. Using the config LGTM. Wdyt @roeierez?

Yes I am fine with using the config

dangeross
dangeross approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@dangeross dangeross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hydra-yse
hydra-yse approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@hydra-yse hydra-yse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

roeierez
roeierez approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@roeierez roeierez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! A small comment regarding default value.

lib/bindings/src/breez_sdk_liquid.udl Outdated
@@ -335,6 +335,7 @@ dictionary Config {
string? breez_api_key;
string? cache_dir;
u64? zero_conf_max_amount_sat;
sequence<ExternalInputParser>? external_input_parsers;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we changes that so by default it will be null? This will create it as an optional parameter in some languages:
sequence<ExternalInputParser>? external_input_parsers = null;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied in 3705175

roeierez
roeierez approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@roeierez roeierez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielgranhao danielgranhao merged commit 8540cfe into main Dec 12, 2024
8 checks passed
@danielgranhao danielgranhao deleted the external-input-parsing branch December 12, 2024 18:39
This was referenced Dec 13, 2024
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hydra-yse hydra-yse hydra-yse approved these changes

@roeierez roeierez roeierez approved these changes

@dangeross dangeross dangeross approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danielgranhao @dangeross @roeierez @hydra-yse