Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document amountless swaps #57

Merged
merged 5 commits into from
Jan 14, 2025
Merged

Document amountless swaps #57

merged 5 commits into from
Jan 14, 2025

Conversation

danielgranhao
Copy link
Contributor

@danielgranhao danielgranhao commented Jan 2, 2025 •
edited
Loading

Adds documentation for amountless swaps, including:

  • that the swap limits must still be respected
  • how fees during preparation are only estimations
  • the need to accept fees if onchain fee rate has risen
  • the possibility to set a leeway for auto accepting new fees

TODO:

  • Develop snippets for all languages besides Rust (let's first agree on the snippet contents)
  • Update snippets once the new SDK version is released

@danielgranhao danielgranhao force-pushed the daniel-chain-swap-fee-acceptance branch from 77ac780 to 8dd4447 Compare January 2, 2025 17:23
@danielgranhao danielgranhao force-pushed the daniel-chain-swap-fee-acceptance branch from 8dd4447 to 91759d8 Compare January 2, 2025 17:29
dangeross
dangeross reviewed Jan 2, 2025
View reviewed changes
Copy link
Contributor

@dangeross dangeross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Not for this PR, but I think it would be good to start an Advanced Config page to give examples of different config options

@danielgranhao
Copy link
Contributor Author

Not for this PR, but I think it would be good to start an Advanced Config page to give examples of different config options

Agreed. I had the same idea. Created #58.

@danielgranhao danielgranhao marked this pull request as ready for review January 13, 2025 12:19
@danielgranhao danielgranhao mentioned this pull request Jan 13, 2025
Closed
dangeross
dangeross approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@dangeross dangeross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielgranhao danielgranhao merged commit f7a64c1 into external-input-parsing Jan 14, 2025
68 checks passed
@danielgranhao danielgranhao deleted the daniel-chain-swap-fee-acceptance branch January 14, 2025 11:55
danielgranhao added a commit that referenced this pull request Jan 20, 2025
@danielgranhao
Document input parsing and amountless swaps (#56)
4cef313 
* Add "Parsing inputs" page

* Fix input placeholder not being shown

* Fix react native linting errors

* Add external parser configuration snippet

* Fix python snippet

* Document default external input parsers

* Document amountless swaps (#57)

* Document amountless swaps

* Add snippets for remaining languages

* Update SDK version and apply various fixes

* Drop use of python match case

* Fix version in workflow file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dangeross dangeross dangeross approved these changes

@hydra-yse hydra-yse Awaiting requested review from hydra-yse

@roeierez roeierez Awaiting requested review from roeierez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielgranhao @dangeross