Implement prepare_refund()
#548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielgranhao
force-pushed
the
23-20-2023-implement-prepare-refund
branch
3 times, most recently
from
af59cfe to
129da31
Compare
roeierez
requested changes
Oct 24, 2023
libs/sdk-core/src/swap.rs
Outdated
Comment on lines
441
to
450
| let swap_info = self | ||
| .persister | ||
| .get_swap_info_by_address(req.swap_address.clone())? | ||
| .ok_or_else(|| anyhow!(format!("swap address {} was not found", req.swap_address)))?; | ||
|
|
||
| let transactions = self | ||
| .chain_service | ||
| .address_transactions(req.swap_address.clone()) | ||
| .await?; | ||
| let utxos = get_utxos(req.swap_address, transactions)?; |
There was a problem hiding this comment.
Perhaps we can extract out this code to a function that can be reused in refund_swap function?
There was a problem hiding this comment.
Makes sense. Addressed in a2308ba
danielgranhao
force-pushed
the
23-20-2023-implement-prepare-refund
branch
from
129da31 to
a2308ba
Compare
I've just rebased and run the generator again. I didn't see any changes. |
dangeross
approved these changes
Oct 24, 2023
4 tasks
|
@danielgranhao this is ready to be merged. We will merge it right after the conflict is resolved. Thanks. |
danielgranhao
force-pushed
the
23-20-2023-implement-prepare-refund
branch
from
a2308ba to
ee2f2fa
Compare
* Created `get_address_utxos` * Created `get_swap_info_ok`
danielgranhao
force-pushed
the
23-20-2023-implement-prepare-refund
branch
from
ee2f2fa to
88207b5
Compare
|
@roeierez Conflicts should be resolved now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #526.