-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add conanfile #110
base: master
Are you sure you want to change the base?
Add conanfile #110
Conversation
It looks like there is a bug because EXPAT_INCLUDE_DIR is set, but EXPAT_INCLUDE_DIRS is used. So expat paths were not visible while make running. Fixing name helped.
… for debug build on Windows - Added optional include of conanbuildinfo.txt in project CMakeLists.txt - Added conanfile.py with receipt to build conan package and written dependenices as conan packages - Added conan build instruction to README.md
Also, what is the reason the line:
was changed to:
As for Conan, I don't have any experience with that (yet), but I'm okay with that if you have tested your files on different platforms supported by Conan. |
|
Wouldn't it make more sense to report to the CMake developer(s) that
if(EXPAT_FOUND)
set(EXPAT_LIBRARIES ${EXPAT_LIBRARY})
set(EXPAT_INCLUDE_DIRS ${EXPAT_INCLUDE_DIR}) so if Expat is found |
I'l try to explain chronologically.
On this point i created first pull request After that I created Conan package, for my purposes and decided that it will be usefull for somebody. |
#108 already fixes |
Added conanfile.py for building as Conan package, with linked dependencies
It is good idea to push xlsxio to center.conan.io in future as Conan package