Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github actions: remove rust-cache #351

Merged
merged 1 commit into from
Jan 18, 2024
Merged

github actions: remove rust-cache #351

merged 1 commit into from
Jan 18, 2024

Conversation

rillian
Copy link
Contributor

@rillian rillian commented Jan 16, 2024

Now that we're trying to review changes to github action scripts, it may not be worthwhile to use the cache. Experiment with removing it to see how that affects ci performance.

Now that we're trying to review changes to github action scripts,
it may not be worthwhile to use the cache. Experiment with removing
it to see how that affects ci performance.
@rillian rillian self-assigned this Jan 16, 2024
@rillian rillian requested a review from a team as a code owner January 16, 2024 19:16
@rillian
Copy link
Contributor Author

rillian commented Jan 16, 2024

There's a lot of variance in the runtimes for test and style jobs, so while the runtimes with this change are longer than the immediately previous ones, they're not particularly longer than the recent history, even excepting the previous change to the cache code. No difference with the security or clippy runs.

Given that and (new?) telemetry code added by #350, I prefer removing the cache in favour of tracking one less dependency.

Copy link
Member

@claucece claucece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. this makes sense.

@rillian rillian merged commit db41ffb into main Jan 18, 2024
11 checks passed
@rillian rillian deleted the nocache branch January 18, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants