Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the new resolver for all crates #317

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Use the new resolver for all crates #317

merged 1 commit into from
Sep 18, 2023

Conversation

rillian
Copy link
Contributor

@rillian rillian commented Sep 18, 2023

Address a warning with recent (1.7x) toolchains about the dependency resolver version. Some of the crates in the shared workspace of this repository declare themselves edition="2018" while others declare edition="2021". The two editions specify different dependency resolution engines. We can use either, so pick the newer one when building as part of the workspace.

This can be removed when all crates are on the 2021 edition.

Address a warning with recent (1.7x) toolchains about the dependency
resolver version. Some of the crates in the shared workspace of
this repository declare themselves edition="2018" while others
declare edition="2021". The two editions specify different
dependency resolution engines. We can use either, so pick the
newer one when building as part of the workspace.

This can be removed when all crates are on the 2021 edition.
@rillian rillian requested a review from a team as a code owner September 18, 2023 14:36
@rillian rillian self-assigned this Sep 18, 2023
@rillian rillian enabled auto-merge September 18, 2023 14:54
@rillian rillian merged commit d799708 into main Sep 18, 2023
Copy link
Member

@claucece claucece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@rillian rillian deleted the resolver branch September 18, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants