Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Desktop Rewards test cases #556

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Update Desktop Rewards test cases #556

merged 1 commit into from
Nov 27, 2023

Conversation

LaurenWags
Copy link
Member

Fix #522

  • Updated Rewards test cases

@LaurenWags LaurenWags self-assigned this Nov 27, 2023
stephendonner
stephendonner approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@stephendonner stephendonner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for taking care of this! r+

@LaurenWags LaurenWags merged commit 2068e3d into master Nov 27, 2023
1 check passed
@LaurenWags LaurenWags deleted the laurenwags-issue-522 branch November 27, 2023 16:51
@GeetaSarvadnya
Copy link
Collaborator

GeetaSarvadnya commented Nov 28, 2023 •
edited
Loading

@LaurenWags: Updated files looks great. Can we add a case to verify the Send contribution button is greyedout or disabled for unverified creators below the line number +134?
Thanks for removing unwanted cases and updating the existing cases as per the new design. Great work,Thanks!

image

@LaurenWags LaurenWags mentioned this pull request Nov 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephendonner stephendonner stephendonner approved these changes

@GeetaSarvadnya GeetaSarvadnya Awaiting requested review from GeetaSarvadnya

Assignees

@LaurenWags LaurenWags

Labels
OS/Desktop testsheet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update desktop rewards test cases
3 participants
@LaurenWags @GeetaSarvadnya @stephendonner